Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Server 1.24 related fixes #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Server 1.24 related fixes #551

merged 1 commit into from
Jun 17, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Jun 17, 2024

What was changed

  • Fix schedule test assertions that expect certain num actions on backfill (backfill logic changed in 1.24)
  • Fix schedule test assertions that expect untyped search attributes (search attributes for scheduled workflows are mapped to proper types in 1.24)
  • Fix issue found during schedule test assertions where we were improperly checking against a shadowed variable when appending search attributes

@cretz cretz requested a review from a team as a code owner June 17, 2024 15:45
antlai-temporal
antlai-temporal approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@antlai-temporal antlai-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are any of these changes customer visible? Do we need to change docs?

@cretz
Copy link
Member Author

cretz commented Jun 17, 2024

Are any of these changes customer visible? Do we need to change docs?

Nothing in this PR. If not already clear in server release notes that schedule workflows now properly set types on search attributes, it may need to, but nothing here.

@cretz cretz merged commit 18b890e into temporalio:main Jun 17, 2024
12 checks passed
@cretz cretz deleted the server-1.24-test-fix branch June 17, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antlai-temporal antlai-temporal antlai-temporal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @antlai-temporal