Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unfinished handlers: add rule and test CAN, dynamic, and late-registered handlers #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 19, 2024
Merged

Unfinished handlers: add rule and test CAN, dynamic, and late-registered handlers #612

merged 7 commits into from
Aug 19, 2024

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Aug 16, 2024 •
edited
Loading

Closes #584

  • Add the [TMPR1102] rule tag to the warning messages
  • Add tests confirming that the all_handlers_finished and warnings logic work for continue-as-new, dynamic handlers, and late-registered handlers.
  • Refactor all tests as a pytest.mark.parametrize Cartesian product

@dandavison dandavison force-pushed the 584-unfinished-handlers-can-and-dynamic branch 2 times, most recently from 70a9e9e to af36ef2 Compare August 17, 2024 02:57
@dandavison dandavison marked this pull request as ready for review August 17, 2024 02:57
@dandavison dandavison requested a review from a team as a code owner August 17, 2024 02:57
@dandavison dandavison changed the title 584 unfinished handlers can and dynamic Unfinished handlers: add rule and test CAN, dynamic, and late-registered handlers Aug 17, 2024
@dandavison dandavison mentioned this pull request Aug 19, 2024
Closed
@dandavison dandavison force-pushed the 584-unfinished-handlers-can-and-dynamic branch from 46687a0 to c0d7594 Compare August 19, 2024 11:32
@dandavison dandavison force-pushed the 584-unfinished-handlers-can-and-dynamic branch from c0d7594 to 5144f05 Compare August 19, 2024 17:38
@dandavison dandavison merged commit 97688cc into main Aug 19, 2024
12 checks passed
@dandavison dandavison deleted the 584-unfinished-handlers-can-and-dynamic branch August 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unfinished handlers: continue-as-new and dynamic handlers
2 participants
@dandavison @cretz