Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Insert guard clause for workflow.upsert_search_attributes on empty inputs #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2024
Merged

Insert guard clause for workflow.upsert_search_attributes on empty inputs #630

merged 4 commits into from
Sep 30, 2024

Conversation

accupham
Copy link
Contributor

@accupham accupham commented Sep 2, 2024

Fix for #629

What was changed

Guard clause on workflow.upsert_search_attributes so SDK doesn't crash on empty input.

Why?

Spent 5 hours debugging an inscrutable error message.

Checklist

  1. Closes 629

  2. How was this tested:
    Pass empty list into upsert_search_attributes in a workflow.

  3. Any docs updates needed?
    No

@accupham accupham requested a review from a team as a code owner September 2, 2024 22:22
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cretz
cretz approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! May need to sign CLA.

@accupham
Copy link
Contributor Author

accupham commented Sep 5, 2024

@cretz Signed CLA!

@cretz
Copy link
Member

cretz commented Sep 5, 2024

Thanks! We have a CI failure that is unrelated to this PR. Once it is fixed, we can come back and merge this.

@cretz cretz merged commit 2e6d742 into temporalio:main Sep 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@accupham @CLAassistant @cretz