Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support passing through all modules #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2025
Merged

Support passing through all modules #737

merged 4 commits into from
Jan 23, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 17, 2025

What was changed

  • Added passthrough_all_modules dataclass field to temporalio.worker.workflow_sandbox.SandboxRestrictions class, defaulted to false that, when set to true, will be as if all modules are passed through
  • Added with_passthrough_all_modules helper method to that same class to return a new instance with that value set to true
  • Some README updates clarifying this new setting

Checklist

  1. Closes [Feature Request] Make option for "all passthrough" (i.e. disable import isolation part of sandbox) #691

@cretz cretz requested a review from a team as a code owner January 17, 2025 16:11
@cretz
Copy link
Member Author

cretz commented Jan 21, 2025

@dandavison - this one good? Will merge in a bit if so

@cretz
Copy link
Member Author

cretz commented Jan 23, 2025

Assuming with the minor comment and the other approval that we're good, merging...

@cretz cretz merged commit 4892714 into temporalio:main Jan 23, 2025
13 checks passed
@cretz cretz deleted the passthrough-all-modules branch January 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison left review comments

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make option for "all passthrough" (i.e. disable import isolation part of sandbox)
3 participants
@cretz @dandavison @Sushisource