Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not include self parameter in handlers in test #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

Do not include self parameter in handlers in test #746

merged 1 commit into from
Jan 23, 2025

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Jan 23, 2025 •
edited
Loading

This is one cause of flakes. I believe this change is from incorrect to correct.

@dandavison dandavison marked this pull request as ready for review January 23, 2025 14:57
@dandavison dandavison requested a review from a team as a code owner January 23, 2025 14:57
@dandavison dandavison merged commit 150878f into main Jan 23, 2025
14 checks passed
@dandavison dandavison deleted the fix-flakes-1 branch January 23, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandavison @cretz