Add dynamic config function #842
Conversation
temporalio/workflow.py
Outdated
| class DynamicWorkflowConfig: | ||
| """Returned by functions using the :py:func:`dynamic_config` decorator, see it for more.""" | ||
|
|
||
| failure_exception_types: Sequence[Type[BaseException]] = dataclasses.field( |
There was a problem hiding this comment.
Clarify on this field and the next that if these are set, they override anything in the definition, they are not additive
temporalio/workflow.py
Outdated
| class DynamicWorkflowConfig: | ||
| """Returned by functions using the :py:func:`dynamic_config` decorator, see it for more.""" | ||
|
|
||
| failure_exception_types: Sequence[Type[BaseException]] = dataclasses.field( |
There was a problem hiding this comment.
I think this should be Optional so that even a user-set empty list can override decorator. It's a bit pedantic though.
| "@workflow.dynamic_config can only be used in dynamic workflows, but " | ||
| f"workflow class {workflow_name} ({cls.__name__}) is not dynamic" | ||
| ) | ||
| dynamic_config_fn = member |
There was a problem hiding this comment.
Pedantic, but we should error if this is already set
temporalio/workflow.py
Outdated
| class DynamicWorkflowConfig: | ||
| """Returned by functions using the :py:func:`dynamic_config` decorator, see it for more.""" | ||
|
|
||
| failure_exception_types: Sequence[Type[BaseException]] = dataclasses.field( |
There was a problem hiding this comment.
Kinda too bad this is dynamic only, this is a nice feature regardless heh (as would be a callback where they can choose programmatically whether an exception is task fail or workflow fail)
There was a problem hiding this comment.
Yeah, I mean we can shift it to be like that if people ask I suppose - but since it only applies on first WFT for now it's not much different from the defn version
Co-authored-by: Chad Retz <[email protected]>
What was changed
Added
@workflow.dynamic_configfunction which can be used on dynamic workflows to specify per-type overrides to@workflow.defnsettings.Why?
Feature parity w/ Java for workflow versioning
Checklist
Closes
How was this tested:
Added tests
Any docs updates needed?