Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] Opentelemetry bugs/findings #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
schickling opened this issue Oct 22, 2021 · 4 comments · Fixed by #340
Closed
4 tasks done

[Bug] Opentelemetry bugs/findings #330

schickling opened this issue Oct 22, 2021 · 4 comments · Fixed by #340
Assignees
@bergundy
Labels
bug Something isn't working
Milestone
beta

Comments

@schickling
Copy link

schickling commented Oct 22, 2021 •
edited by bergundy
Loading

While trying to setup Opentelemetry support for my app (by following the example project) I was facing the following bugs:

  • The timing seems off (see 18922d 10h) 😂

image

  • Some spans don't use the configured serviceName (e.g. here should be temporal-app instead of OTLPResourceNoServiceName )

CleanShot 2021-10-22 at 17 50 45

  • Non-app/SDK-internal traces should be disabled/hidden by default

image

  • Child workflows are not connected to root workflows (i.e. the child workflow span workflow.execute should be a child span of the root workflow.schedule)

image
@schickling schickling added the bug Something isn't working label Oct 22, 2021
@bergundy
Copy link
Member

Also ContinueAsNew should be traced and the package should be compatible with the Java / Golang opentracing implementation.

@bergundy bergundy self-assigned this Oct 26, 2021
@bergundy bergundy added this to the beta milestone Oct 26, 2021
@bergundy
Copy link
Member

@schickling this is one of the next items on my list.

@bergundy
Copy link
Member

OLTPResourceNoServiceName is caused by not passing the created otel resource to makeWorkflowExporter.
I'll make it required.

@bergundy
Copy link
Member

I'm marking things I solved locally as done, will make a PR when it's all done.

@bergundy bergundy mentioned this issue Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bergundy bergundy

Labels
bug Something isn't working
Projects
None yet
Milestone
beta
Development

Successfully merging a pull request may close this issue.

fix: Fix opentelemetry interceptors temporalio/sdk-typescript
2 participants
@bergundy @schickling