Fix clients being created without prefixed metric meter #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jun 12, 2024
cretz
reviewed
Jun 12, 2024
packages/test/src/test-prometheus.ts
Outdated
| @@ -105,6 +105,9 @@ test.serial('Exporting Prometheus metrics from Core works with lots of options', | |||
| ); | |||
| // Verify 'total' suffix | |||
| t.assert(text.includes('temporal_worker_start_total')); | |||
| // Verify prefix exists on client request metrics | |||
| console.log(text); | |||
mjameswh
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Please remove the console.log() line before merging.
Thanks, @Sushisource, for fixing this.
mjameswh
added a commit
to mjameswh/sdk-typescript
that referenced
this pull request
Jul 15, 2024
mjameswh
added a commit
to mjameswh/sdk-typescript
that referenced
this pull request
Jul 16, 2024
mjameswh
added a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Client metrics were being emitted without the prefix
Why?
Bug
Checklist
Closes [Bug] Emitted client metrics missing temporal_ prefix #1440
How was this tested: