feat: Add OTel correlation metadata on emitted logs from Workflow and Activity context loggers #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Activity context loggers
Sushisource
approved these changes
Nov 19, 2024
Co-authored-by: Spencer Judge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add OpenTelemetry's Trace and Span IDs on log entries emitted using the Workflow and Activity context loggers, if appropriate. This allows log correlation on OpenTelemetry aggregators that supports that feature. Resolves [Feature Request] Add OTEL tracing information as attribute on log messages emitted using Workflow Logger #1425.
Fix some misbehaving OTel-related tests.
Add some clarifications regarding Runtime's OpenTelemetry metrics exporter configuration.