fix(workflow): Throw if patches are used at Workflow top level #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23e0b71 to
46ba7f2
Compare
Sushisource
reviewed
Nov 10, 2021
Comment on lines
+602
to
+606
| ( | ||
| j | ||
| ): j is NonNullableObject< | ||
| Pick<coresdk.workflow_activation.IWFActivationJob, 'notifyHasPatch'> | ||
| > => j.notifyHasPatch != null |
There was a problem hiding this comment.
Oh my god this is some nauseating formatting (I know it's auto-formatted, but, jesus)
There was a problem hiding this comment.
lol, I can declare the type somewhere else so the formatting is fixed
Sushisource
approved these changes
Nov 10, 2021
Comment on lines
+198
to
+201
| await context.evalClosure('lib.initRuntime($0, $1)', [options, isolateExtension.derefInto()], { | ||
| arguments: { copy: true }, | ||
| timeout: isolateExecutionTimeoutMs, | ||
| }); |
| const { isReplaying } = state.info; | ||
| const { isReplaying } = workflowInfo(); | ||
| if (state.workflow === undefined) { | ||
| throw new IllegalStateError('Patches cannot be used before Workflow starts'); |
There was a problem hiding this comment.
Lift string to constant for assertion in test?
There was a problem hiding this comment.
It's just 1 test, I can but I wouldn't bother
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362