Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Defaulted WorkflowHandle T generics to Workflow #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2021
Merged

Defaulted WorkflowHandle T generics to Workflow #419

merged 1 commit into from
Dec 5, 2021

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 5, 2021 •
edited
Loading

What was changed

Added T extends Workflow = Workflow defaults for WorkflowHandle & co.

Why?

This way workflow handle type declarations don't need to pass around their workflow type.

Checklist

  1. Closes [Feature Request] Generic workflow defaults: T extends Workflow = Workflow #418

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 5, 2021 03:43
bergundy
bergundy approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bergundy
Copy link
Member

bergundy commented Dec 5, 2021

We could probably add a default to ChildWorkflowHandle but I'm going to merge this already.

@bergundy bergundy merged commit 0151e30 into temporalio:main Dec 5, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the t-extends-workflow-equals branch December 5, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Generic workflow defaults: T extends Workflow = Workflow
2 participants
@JoshuaKGoldberg @bergundy