chore: Remove unused deps; Upgrade protobufjs; Publish src #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorensr
approved these changes
Jun 23, 2022
Comment on lines
-29
to
-31
| "files": [ | ||
| "lib" | ||
| ], |
There was a problem hiding this comment.
Keeping this as:
"lib", "src"
would prevent unneeded files getting published, like .tsbuildinfo and tsconfig.json
packages/common/package.json
Outdated
| @@ -14,16 +14,14 @@ | |||
| "dependencies": { | |||
| "@temporalio/internal-workflow-common": "file:../internal-workflow-common", | |||
| "@temporalio/proto": "file:../proto", | |||
| "proto3-json-serializer": "^0.1.6" | |||
| "proto3-json-serializer": "^1.0.2", | |||
| "protobufjs": "^6.11.3" | |||
There was a problem hiding this comment.
I think the only reference in this package is:
import type { Message, Namespace, Root, Type } from 'protobufjs';Does that mean it should be a devDep?
| "@types/rimraf": "^3.0.0", | ||
| "@types/tar": "^4.0.3", | ||
| "@types/validate-npm-package-name": "^3.0.0" | ||
| "@types/node": "^18.0.0", |
There was a problem hiding this comment.
Intended? (repeated below)
| "files": [ | ||
| "lib", | ||
| "workflow-isolate-extension.cc", | ||
| "binding.gyp" |
There was a problem hiding this comment.
More files in this list to add back
c2a97a4 to
50a1928
Compare
Upgrade all packages Is it fixed? It will work eventually Downgrade glob Re-add files to published packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.