Attach user metadata from commands to corresponding history events #5857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gow
commented
May 7, 2024
Member
|
Will let others more familiar with this repo review. But I want to confirm that some features will be present:
|
Contributor
Author
This is PR is just for commands only (to keep PRs short). I'm working on another PR to include user metadata in all the other areas you mentioned. |
yycptt
approved these changes
May 13, 2024
Member
yycptt
left a comment
There was a problem hiding this comment.
Workflow task handler logic LGTM
11 tasks
This was referenced Aug 19, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In this PR we are attaching the user metadata if found in the command to the corresponding history events that are being created.
Why?
Users need a way to set arbitrary information on workflows and events. This would be later used in the clients to build custom tooling (ex: UI showing additional information about a timer event etc)
How did you test it?
Added unit tests
Potential risks
N/A. It is backward compatible.
Documentation
N/A
Is hotfix candidate?
No