Keep dots in Build IDs and format Worker Deployment names <k8s-namespace>/<twd-name>
#133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Keep dots in Build IDs and format Worker Deployment names
<k8s-namespace>/<twd-name>Why?
Dots are allowed in pod names and its nice to maintain the semantic version appearance of an image.
Namespace first means the same alphabetization as
kubectl list --all-namespaces.Namespace first is more expected for a slash delimiter that implies hierarchy
Checklist
Closes
How was this tested:
Unit tests and functional tests
Any docs updates needed?