Sanitize build IDs to match k8s label value requirements #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
approved these changes
Sep 10, 2025
Collaborator
|
if it's easy to make one of the existing functional tests pass in an image name with a banned character in it, it would be nice to see that work, but I'm pretty sure it will work since we're doing this at the very beginning |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Build IDs are now sanitized in order to match k8s label value requirements.
Why?
This ensures that the value of the label
temporal.io/build-idapplied by the controller to k8s resources can match the build ID registered with Temporal.Checklist
N/A
Unit tests updated
No