Update demo scripts #145
Merged
Update demo scripts #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec65cd4 to
138ad70
Compare
d1b78c7 to
ed61c96
Compare
carlydf
approved these changes
Sep 22, 2025
Collaborator
carlydf
left a comment
There was a problem hiding this comment.
approved with some questions
internal/demo/helloworld/helm/helloworld/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
Shivs11
approved these changes
Sep 24, 2025
Member
Shivs11
left a comment
There was a problem hiding this comment.
tysm for fixing the broken demo!
c808187 to
fe96710
Compare
fe96710 to
0fd10eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
skaffold.env(gitignored)Why?
These changes make it possible to run the demo in a custom k8s context (not minikube) and against a configurable Temporal cloud namespace or self-hosted cluster without modifying checked-in files.
Also, the demo build was broken. 😅
Checklist
Closes Trouble running demo steps #142
How was this tested:
Manually ran each command in the demo readme
Demo readme includes a few updates.