Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: Initial deployment without current version does not get promoted #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shivs11 merged 6 commits into from
Oct 2, 2025
Merged

Fix: Initial deployment without current version does not get promoted #148

Shivs11 merged 6 commits into from
Oct 2, 2025

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Sep 26, 2025 •
edited
Loading

What was changed

  • Right now, if someone were to deploy the first version of a fresh new deployment, the version keeps on being Inactive and does not get promoted to Current immediately.
  • Note: This only happens if there is a gated workflow specified on a TWD. This bug does not take place when there isn't a gated workflow.

Why?

  • We have the following invariant: Note that when there is no current version (as in an initial versioned worker deployment), the progressive steps are skipped and v1 becomes the current version immediately. All new workflow executions will now start on v1.

Checklist

  1. Closes

  2. How was this tested:

  • Added two new unit tests.
  • Also tested this out locally.
  • Integration tests.
  1. Any docs updates needed?

@Shivs11 Shivs11 requested review from a team and jlegrone as code owners September 26, 2025 17:19
@Shivs11 Shivs11 marked this pull request as draft September 26, 2025 17:29
Shivs11
Shivs11 commented Sep 26, 2025
View reviewed changes
@Shivs11 Shivs11 marked this pull request as ready for review September 26, 2025 18:07
@Shivs11 Shivs11 mentioned this pull request Sep 30, 2025
Merged
carlydf
carlydf reviewed Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@carlydf carlydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like the bug you're fixing is that the initial rollout of a version does not work when there is a gate workflow enabled. But initial rollout does work if gate is nil; is that right?
Could you change the title / description of your PR to be more specific about that, and also add a functional test case for this scenario?

carlydf
carlydf approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@carlydf carlydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved once you remove the duplicate test and change the title of the PR to better describe the problem that was fixed

@Shivs11 Shivs11 changed the title fix bootstrap bug Fix: Initial deployment without current version does not get promoted Oct 1, 2025
@Shivs11 Shivs11 merged commit 435a91e into temporalio:main Oct 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlydf carlydf carlydf approved these changes

@jlegrone jlegrone Awaiting requested review from jlegrone jlegrone is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shivs11 @carlydf