Tags: temporalio/temporal-worker-controller
Tags
Bug Fix: Ignore LastModifierIdentity if server deleted a version for … …garbage collection (#163) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Bug Fix: Ignore LastModifierIdentity if server deleted a version for garbage collection Also, fix issue in describe version that would sometimes cause a deprecated version to be Drained with nil DrainedSince time. ## Why? The server sets the `LastModifierIdentity` to `"try-delete-for-add-version"` when it deletes old versions to do garbage collection upon addition of the a worker version beyond the maximum. We are changing this on the server and will patch v1.29 of the OSS server to handle this more gracefully in v1.29.2 of the server, however, for users who cannot or do not want to use the new patch of the server immediately, this will fix the problem for them on the controller side so that they won't encounter this if they're running against Temporal Server v1.29.1 or v1.29.0. The issue of nil DrainedSince time caused flakiness in tests that involve Deprecated Drained versions. That flakiness appeared a lot in the new test I added to test the bug fix, so I also fixed that. ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: New functional test 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
update documentation to reflect connectionRef and mutualTLSSecretRef … …changes in #136 (#154) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed updated documentation to reflect connectionRef and mutualTLSSecretRef changes in #136 ## Why? The current documentation is outdated
Remove nonexistent Gate options from docs (#151) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Remove nonexistent Gate options from docs ## Why? So as to not confuse users ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
Only Delete Deployments of NotRegistered versions if TemporalState is… … non-empty (#147) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed? Only Delete Deployments of NotRegistered versions if TemporalState is non-empty ## Why? TemporalState can be empty on the initial rollout of a Worker Deployment, if no versioned workers have ever polled. In that case we need to continue the reconcile loop to create the worker pods which will poll and create the Worker Deployment. TemporalState can also, rarely, be empty if the server returns a transient NotFound error, which can happen at any time in a Worker Deployment's life. If TemporalState is empty when there are Deprecated Versions around, it is important that we do not take an empty TemporalState to mean that those Deprecated Versions are NotRegistered and should be deleted, because that would cause the controller to delete those Deployments despite the fact that they are actually draining. This change prevents that. ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: Unit test 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
Refactor README for Public Preview (#137) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed Refactor README ## Why? Update information and make it more user friendly ## Checklist <!--- add/delete as needed ---> 1. Closes #87 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
Update release.yml (#124) Address the error in the actions logs <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed <!-- Describe what has changed in this PR --> ## Why? <!-- Tell your future self why have you made these changes --> ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
Update release.yml to use temporal-cicd[bot] (#120) ## What was changed Change how the bot identifies itself ## Why? Actions cannot be added to bypass lists ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
PreviousNext