feat(run): run command supports docker runner - #2042
Merged
Conversation
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Contributor
Author
Contributor
Author
|
envd run gpu settings still have bugs, currently being fixed. |
kemingy
reviewed
Oct 27, 2025
Comment on lines
-229
to
-234
| for _, p := range ports { | ||
| if p.Port == 2222 { | ||
| continue | ||
| } | ||
|
|
||
| // TODO(gaocegege): Use one remote port. |
Member
There was a problem hiding this comment.
Hi @gaocegege , do you remember why we need to go through all the ports here and why the TODO shows "use one remote port"?
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Signed-off-by: zhangwei <[email protected]>
Contributor
Author
kemingy
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Command Help
Use example
envd run --image timesfm:dev-v2 --name timesfmenvd run --image timesfm:dev-v2 --gpus 2 --name timesfmenvd run --image timesfm:dev-v2 --gpu-set '"device=1,3"' --name timesfmenvd run --image timesfm:dev-v2 --gpu-set '"device=1,3"' --gpus 4 --name timesfm