feat: add codex template - #2054
Merged
Merged
Conversation
Signed-off-by: Keming <[email protected]>
kemingy
requested review from
VoVAllen,
gaocegege,
lalawuu and
zwpaper
as code owners
November 5, 2025 15:08
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codex agent installation to use musl-based binaries instead of glibc-based ones, updates base APT packages to support both version 5 and 6 of libtinfo and libncursesw libraries, and adds a new codex template file. Additionally, it optimizes UV Python installation to skip for sudo when dev=True.
- Changed codex agent downloads from
linux-gnutolinux-muslbuilds - Updated base APT packages to use pattern matching for library versions (
libtinfo[56]andlibncursesw[56]) - Added early return in UV compilation when
dev=Trueto avoid redundant Python installation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/envd.go | Updated base APT packages to use version-flexible patterns for ncurses libraries |
| pkg/lang/ir/v1/uv.go | Added conditional early return to skip UV Python installation for sudo when dev mode is enabled |
| pkg/lang/ir/v1/compile.go | Corrected comment from "re-install" to "install" for clarity |
| pkg/lang/ir/v1/agent.go | Changed codex binary downloads from glibc (linux-gnu) to musl (linux-musl), removed glibc version warning and unused logrus import |
| pkg/app/template/codex.envd | Added new template file for codex environment setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codex.envdtemplate, try it withenvd new -t codexdev=True