Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yongtang
Copy link
Member

@yongtang yongtang commented Jan 3, 2019

This fix updates Apache Arrow to 0.11.1. Since Parquet is part of the Apache Arrow now, the Parquet library has been removed.

The Parquet headers are still generated like before, except it is included as part of the arrow/cpp/src/parquet.

Signed-off-by: Yong Tang [email protected]

@yongtang yongtang force-pushed the arrow branch 2 times, most recently from 72c9811 to d384a02 Compare January 3, 2019 22:03
This fix updates Apache Arrow to 0.11.1. Since Parquet is
part of the Apache Arrow now, the Parquet library has been removed.
The Parquet headers are still generated like before, except
it is included as part of the arrow/cpp/src/parquet.

Signed-off-by: Yong Tang <[email protected]>
@yongtang
Copy link
Member Author

yongtang commented Jan 3, 2019

@BryanCutler It looks like the Parquet Cpp library is now part of the Arrow library. I update the arrow dependency (with parquet related cpp files added) and removed the parquet dependency in the PR. Please take a look.

@BryanCutler
Copy link
Member

BryanCutler commented Jan 4, 2019

Thanks for doing this! For #36 I also needed a number of source files in arrow/ipc and arrow/io as well as the Flatbuffers compiler, which I added here. Would you like me to make a PR to add them here or just update my branch once this is merged?

@yongtang
Copy link
Member Author

yongtang commented Jan 4, 2019

Thanks @BryanCutler. I think we could merge this PR now, then additional needed source files (in arrow.BUILD) could be added from your arrow PR there. Let me merge this PR.

@yongtang yongtang merged commit c88d9b3 into tensorflow:master Jan 4, 2019
@yongtang yongtang deleted the arrow branch January 4, 2019 05:57
@BryanCutler
Copy link
Member

Thanks @BryanCutler. I think we could merge this PR now, then additional needed source files (in arrow.BUILD) could be added from your arrow PR there. Let me merge this PR.

Sounds good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants