-
Notifications
You must be signed in to change notification settings - Fork 307
Travis CI build enhancements #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fix moves top level tf to third_party/tf to reduced the top level directories. The tf directory itself is to configure the tensorflow headers to be used. Signed-off-by: Yong Tang <[email protected]>
5936012 to
def9a9c
Compare
as Ubuntu 16.04 and 18.04 may have new C++ compilers Signed-off-by: Yong Tang <[email protected]>
f81fd1c to
524a201
Compare
and fix arrow build failure in Ubuntu 18.04 Signed-off-by: Yong Tang <[email protected]>
also, add Build test so that generated whl files could be tested. Signed-off-by: Yong Tang <[email protected]>
ff1a6bf to
364c645
Compare
… release tensorflow-io Signed-off-by: Yong Tang <[email protected]>
|
/cc @terrytangyuan @dmitrievanthony to take a look. Basic story: provide coverage for supported platforms. When we provide a list of supported platforms, we are talking about several things:
In detail:
|
|
All tests passes now. I think this PR is ready for review. |
|
@yongtang I changed the travis config for R to this recently: Lines 97 to 110 in e5dc0eb
This includes the following:
Could you incorporate the above mentioned items in the PR? |
|
@terrytangyuan The PR made changes to CI so now R is tested inside docker containers with Ubuntu 16.04 and 18.04. This is actually different from Travis CI's Ubuntu 14.04 VM and R language spec. The reason to test inside Ubuntu 16.04 and 18.04 containers is that users are more likely to use Ubuntu 16.04/18.04 than Travis CI's Ubuntu 14.04. (The Ubuntu 14.04 will be out of support in April). Also, Travis CI still hasn't been able to support Ubuntu 18.04 today. With tests running inside containers some of the optimizations may not be applications. I managed to have the following two in pace in containers:
Please take a look and see if it helps. |
|
@yongtang Thanks. That makes sense and the changes look fine to me. I'll probably add the additional work that Looks like the exit code of |
Signed-off-by: Yong Tang <[email protected]> Add -v $HOME/.cache/pip:/root/.cache/pip to cache pip in docker containers Signed-off-by: Yong Tang <[email protected]>
2d77507 to
052345b
Compare
…to capture errors and add ffmpeg install to fix R build failure. Signed-off-by: Yong Tang <[email protected]>
|
Thanks @terrytangyuan. I updated the PR and the failed R tests on ffmpeg have been fixed. Also changed the check code to |
terrytangyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the efforts!
This PR will try to enhance the Travis CI builds. While Travis CI builds have been very helpful, there are several issues.
Travis CI only have Ubuntu 14.04 and 16.04 for VM. No Ubuntu 18.04, and 14.04 LTS will not be supported after April.
The Python version installed by default in Travis CI is not the same as Ubuntu system Python. That triggers issues for 3.6 (TensorFlow 1.13 support #56 (comment))
When we release tensorflow-io, we build whl files in docker image
tensorflow/tensorflow:custom-op. The version of Python does not necessary match, seeThe generated whl files in tensorflow-io was not tested on Ubuntu 16.04 and 18.04.
This PR has the intension of
Bazel test //tensorflow_io/...) intensorflow/tensorflow:custom-op, with python versions matching tensorflow ci build.Bazel test //tensorflow_io/...) in Ubuntu 16.04 and 18.04 docker images (not with Travis VM) with system python 2 and 3.tensorflow/tensorflow:custom-op, with python matching tensorflow ci build.The following are the changes in this PR:
Signed-off-by: Yong Tang [email protected]