Replicate internal cluster changes in official mnist tpu example #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
approved these changes
Apr 23, 2018
qlzh727
reviewed
Apr 23, 2018
| project=FLAGS.gcp_project)) | ||
| tpu_grpc_url = tpu_cluster_resolver.get_master() | ||
| tpu_cluster_resolver = tf.contrib.cluster_resolver.TPUClusterResolver( | ||
| FLAGS.tpu, |
There was a problem hiding this comment.
probably should just use tpu=FLAGS.tpu since tpu is a named param in the constructor.
omegafragger
pushed a commit
to omegafragger/models
that referenced
this pull request
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate some changes to the MNIST TPU example that makes interacting with the cluster more intuitive.
@saeta @frankchn Do we need to wait for a tf-nightly build with your other cluster resolver changes to merge this?