Fix/ncf mlperf tweaks #5334
Merged
Fix/ncf mlperf tweaks #5334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robieta
commented
Sep 19, 2018
- Cleanup run script. Fix hr threshold and add ml_perf flag
- Make exit behavior more stable
- Add seed to reduce variation. There is still unaccounted for variation, but this at least removes some of it.
reedwm
requested changes
Sep 19, 2018
| atexit.register(_shutdown, proc=proc) | ||
| atexit.register(tf.gfile.DeleteRecursively, | ||
| ncf_dataset.cache_paths.cache_root) | ||
| cleanup_called = {"finished": False} |
| @@ -390,6 +396,8 @@ def run_ncf(_): | |||
| if model_helpers.past_stop_threshold(FLAGS.hr_threshold, hr): | |||
| break | |||
|
|
|||
| cleanup_fn() # Cleanup data construction artifacts and subprocess. | |||
There was a problem hiding this comment.
No need to call this, since it's registered with atexit
There was a problem hiding this comment.
This comes from Shawn. He is running in a loop, and is accumulating files because the atexit hasn't triggered yet. I neglected that use case when I decided to rely on atexits.
| num_gpus = flags_core.get_num_gpus(FLAGS) | ||
| batch_size = distribution_utils.per_device_batch_size( | ||
| int(FLAGS.batch_size), num_gpus) | ||
| eval_batch_size = int(FLAGS.eval_batch_size or FLAGS.batch_size) | ||
| ncf_dataset = data_preprocessing.instantiate_pipeline( | ||
| ncf_dataset, cleanup_fn = data_preprocessing.instantiate_pipeline( |
There was a problem hiding this comment.
Pass deterministic=FLAGS.seed is not None
There was a problem hiding this comment.
Good catch. I wonder if this is the reason that I wasn't seeing deterministic behavior. (I'll rerun to test.)
1b180ca to
11c5a43
Compare
reedwm
approved these changes
Sep 19, 2018
added 2 commits
September 19, 2018 16:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.