docs: fix broken links in overview.md#3440
Merged
Merged
Conversation
Fixed 2 broken links
stephanwlee
reviewed
Mar 27, 2020
| ### Can I customize which lines appear in a plot? | ||
|
|
||
| Using the [custom scalars plugin](tensorboard/plugins/custom_scalar), you can | ||
| Using the [custom scalars plugin](https://github.com/tensorflow/tensorboard/tree/master/tensorboard/plugins/custom_scalar), you can |
Contributor
There was a problem hiding this comment.
Could you use a relative path? i.e., ../../../tensorboard/plugins/custom_scalar. Here and below
Contributor
Author
There was a problem hiding this comment.
Sure! I'll work on fixing the other two broken links you pointed out too!
Contributor
There was a problem hiding this comment.
Thank you! For context, the reason that we like relative links is that
they enable editors to cross-link. For instance, in Vim, I can just
press gf (go-file) with my cursor on the relative link and it’ll open
in my editor.
Fixed two additional broken links. Changed previous link fixes to have relative paths.
removed superfluous white space
stephanwlee
requested changes
Mar 27, 2020
Converted all 4 broken links to working relative links
stephanwlee
approved these changes
Mar 27, 2020
Contributor
stephanwlee
left a comment
There was a problem hiding this comment.
Thanks a lot for quick back and forth! 🙇
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Apr 15, 2020
Fixed 2 broken links that were pointed out in tensorflow#2814. Fixes tensorflow#2814.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 2 broken links that were pointed out in #2814.
Fixes #2814.