timeseries: fix runs table scrollable issue#5020
Merged
Merged
Conversation
When a `<runs-table-component>` has height = 100px, the .table-container also had height = 100px which is not what we intended. We intended it to have 100px - heightOfFilterRow. We now use the proper flex syntax for the proper layout. This purely visual bug is hard to test in unit test and will be covered via screenshot tests internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
<runs-table-component>has height = 100px, the .table-containeralso had height = 100px which is not what we intended. We intended it to
have 100px - heightOfFilterRow. We now use the proper flex syntax for
the proper layout.
This purely visual bug is hard to test in unit test and will be covered
via screenshot tests internally.
Fixes #5019.