Fix PR curve plugin to display correct thresholds#5191
Merged
Conversation
Contributor
|
Assigning to Nick who, amongst our team member, is the most knowledgeable person on PR curve. While the description sounds correct, I may not know about the historical background of the plugin. |
nfelt
approved these changes
Aug 10, 2021
Contributor
nfelt
left a comment
There was a problem hiding this comment.
Thank you very much for this fix, and for cleaning up the code and adding tests as well! A bit embarrassing this was overlooked for so long 😅 but glad it's correct now.
Contributor
Author
|
No problem, and thank you for the review! It took me a while to even tell anything was off, so I can definitely understand why it was overlooked 😄 |
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Fix PR curve plugin to display correct thresholds * Fix linter error in _make_pr_entry
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Fix PR curve plugin to display correct thresholds * Fix linter error in _make_pr_entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes:
summary.op.summary.opare:[0.0, 1/(num_thresholds-1), 2/(num_thresholds-1), ..., 1.0]... but prior to this change, the thresholds generated in
_make_pr_entryand displayed in TensorBoard are:[1/num_thresholds, 2/num_thresholds, ..., 1.0].Technical description of changes:
_make_pr_entryto instead generate thresholds likesumamry.op, as described above._make_pr_entryto be a bit easier to read / check for correctness.summary.opthat verify the thresholds used are indeed what are described above.pr_curve_demofrom 50 to 51, since we're now including0in the thresholds.Screenshots of UI changes: N/A (UI is unchanged)
Detailed steps to verify changes work correctly (as executed by you):
pr_curvedirectory.Alternate designs / implementations considered: N/A