router: warn user if there are unsaved edits when navigating away #5223
Merged
Conversation
…m the current route
Member
Author
|
Updated the local test screencast, clicking on back button seems to only work when the navigation is |
stephanwlee
reviewed
Aug 11, 2021
Comment on lines
+26
to
+28
| on(actions.discardDirtyUpdates, (state) => { | ||
| return {...state}; | ||
| }), |
Contributor
There was a problem hiding this comment.
Please undo this change; this is basically noop and we do not need to make changes to the app_routing state based on this action at all.
Comment on lines
+337
to
+341
| expect(actualActions).toEqual([actions.discardDirtyUpdates()]); | ||
|
|
||
| tick(); | ||
| expect(actualActions).toEqual([ | ||
| actions.navigating({ |
Contributor
There was a problem hiding this comment.
I am surprised that the test is passing here. Shouldn't the actualActions be an array with two elements where the first element in the actions.dsicardDirtyUpdates()? Similarly, I expected the L352 to have three elements. What am I missing?
Member
Author
There was a problem hiding this comment.
I used fakeAsync incorrectly as below and it didn't capture the errors :(
it ('wrong test', () => {
fakeAsync(() => {})
});
Fixed now.
stephanwlee
approved these changes
Aug 11, 2021
yatbear
added a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…nsorflow#5223) * warn user if there are unsaved edits when navigating away from the current route * fire discardDirtyUpdates action when user wants to discard unsaved changes
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…nsorflow#5223) * warn user if there are unsaved edits when navigating away from the current route * fire discardDirtyUpdates action when user wants to discard unsaved changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn user with
window.confirmif there are unsaved edits when navigating away from the current route:dispatchNavigating$.