Changing dark mode makes paint dirty#5305
Merged
JamesHollyer merged 1 commit intoOct 28, 2021
Merged
Conversation
stephanwlee
reviewed
Sep 9, 2021
Contributor
There was a problem hiding this comment.
Ah, great. I did not think this would literally be one line fix. Would you mind taking a look at the test and meaningfully prevent regression or detect a bug? (A possible answer is, it is hard to test this in a way that can prevent any regressions and require more integrational style testing such as one that uses WebDriver).
Also, pro-tip: if you type "Fixes #<ISSUE_NUMBER>.", GitHub will automatically close the issue when you merge the PR (https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests).
stephanwlee
approved these changes
Oct 4, 2021
Contributor
stephanwlee
left a comment
There was a problem hiding this comment.
In case testing this is more challenging than adding a few LOC, I am approving the change.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 5246.
Upon initial change from light to dark mode and dark to light mode the graphs used to look like this:
and now they look like this:
The problem was that that change from dark to light mode did lot indicate the the SeriesLineView that the lines were "dirty" so upon update it did not realize they needed to be redrawn.
Fixes #5246.