keep numpy version in pip.sh #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: user home directory is cached between the builds - bazel is picking up the newer version installed after first run of pip.sh Also this should be able to automatically downgrade all the installations in all the jobs on ci.tensorflow.org. But it will need two builds. First one will still pick the new version ob numpy. |
|
Ok, it works. But the first build fails. Just like on this PR. The first bazel build took 1.10.4 cached from previous run and then failed while running test with downgraded 1.8.2. Next runs should work. @tensorflow-jenkins: test this please |
|
Also the docker container build with this works :-) |
martinwicke
added a commit
that referenced
this pull request
Feb 16, 2016
keep numpy version in pip.sh
|
So we need to re-run the release twice to propagate this to the binaries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should keep building against numpy 1.8.2 - the version in ubuntu 14.04.