Codestin Search App

goldiegadde · 2018-10-05T20:49:47Z

No description provided.

…es-1-12

googlebot · 2018-10-05T20:49:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-10-05T20:51:20Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

jsimsa · 2018-10-05T20:51:36Z

+
+* tf.data:
+  * All C++ code moves to the `tensorflow::data` namespace.
+  * Support evaluating with a tf.data.Dataset


this seems incomplete

jsimsa · 2018-10-05T20:57:35Z

+# Release 1.12.0
+
+## Major Features and Improvements
+* tf.data optimizations. Users can now represent, get and set options of a tf.data pipeline.


I would replace this with:

tf.data users can now use tf.data.experimental.AUTOTUNE for the num_parallel_calls argument of tf.data.Dataset.interleave, tf.data.Dataset.map, and tf.data.experimental.map_and_batch to dynamically tune the level of parallelism at runtime.

and move the following to Bug Fixes and Other Changes under tf.data

tf.data users can now represent, get, and set options of TensorFlow input pipelines using tf.data.Options(), tf.data.Dataset.options(), and tf.data.Dataset.with_options() respectively.

let me know when you push the changes and I will take another look

jsimsa · 2018-10-05T20:59:16Z

+  * Adding support for `num_parallel_calls` to `tf.data.Dataset.interleave`.
+* `tf.contrib`:
+  * Remove tf.contrib.linalg.  Library now in tf.linalg.
+  * Replace any calls to tf.contrib.get_signature_def_by_key(metagraph_def, signature_def_key) with meta_graph_def.signature_def[signature_def_key]. Catching a ValueError exception thrown by tf.contrib.get_signature_def_by_key should be replaced by catching a KeyError exception.


anything that is code (e.g. tf.contrib.get_signature_def_by_key(...) should be wrapped in back ticks for proper formatting

annarev · 2018-10-05T20:53:12Z

+  tf.data.AUTOTUNE enables the level of parallelism to be determined at runtime.
+* Keras models can now be directly exported to the SavedModel format and used with Tensorflow Serving.
+
+## Breaking Changes


You can remove this heading if it doesn't have any items.

annarev · 2018-10-05T20:56:27Z

+  * Support evaluating with a tf.data.Dataset
+  * Adding support for `num_parallel_calls` to `tf.data.Dataset.interleave`.
+* `tf.contrib`:
+  * Remove tf.contrib.linalg.  Library now in tf.linalg.


Change it to:
Removed tf.contrib.linalg. tf.linalg should be used instead.

annarev · 2018-10-05T21:00:08Z

+* `tf.contrib`:
+  * Remove tf.contrib.linalg.  Library now in tf.linalg.
+  * Replace any calls to tf.contrib.get_signature_def_by_key(metagraph_def, signature_def_key) with meta_graph_def.signature_def[signature_def_key]. Catching a ValueError exception thrown by tf.contrib.get_signature_def_by_key should be replaced by catching a KeyError exception.
+  * Keras model can be exported to the SavedModel format using tf.contrib.saved_model.save_keras_model().


Sounds similar to the note in "Major Features":
"Keras models can now be directly exported to the SavedModel format and used with Tensorflow Serving."

Can you merge these two? May be put:
"Keras models can now be directly exported to the SavedModel format (tf.contrib.saved_model.save_keras_model()) and used with Tensorflow Serving. "
in Major Features?

annarev · 2018-10-05T21:00:37Z

+  * deprecated, and replaced by `tf.data.experimental`.
+* Other:
+  * Instead of jemalloc, revert back to using system malloc.
+  * Build TensorFlow with XLA support included by default.


This sounds like a major change.

googlebot · 2018-10-05T21:34:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot · 2018-10-05T22:24:13Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

…es-1-12

googlebot · 2018-10-08T18:03:59Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Imported from GitHub PR openxla/xla#22782 Copybara import of the project: -- 6a1fd278aedbfade2accaf18888ca0033ae51fb2 by Ilia Sergachev <[email protected]>: [NFC] Move HLO-handling functions from runner to module util. Merging this change closes #22782 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22782 from openxla:refactor_hlo_fn 6a1fd278aedbfade2accaf18888ca0033ae51fb2 PiperOrigin-RevId: 727874131

Imported from GitHub PR openxla/xla#22782 Copybara import of the project: -- 6a1fd278aedbfade2accaf18888ca0033ae51fb2 by Ilia Sergachev <[email protected]>: [NFC] Move HLO-handling functions from runner to module util. Merging this change closes #22782 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22782 from openxla:refactor_hlo_fn 6a1fd278aedbfade2accaf18888ca0033ae51fb2 PiperOrigin-RevId: 727887880

Imported from GitHub PR openxla/xla#22782 Copybara import of the project: -- 6a1fd278aedbfade2accaf18888ca0033ae51fb2 by Ilia Sergachev <[email protected]>: [NFC] Move HLO-handling functions from runner to module util. Merging this change closes #22782 PiperOrigin-RevId: 729031048

Goldie Gadde and others added 3 commits October 5, 2018 13:41

Adding release notes for 1.12

35b2936

Adding release notes for 1.12

9335fae

Merge branch 'r1.12' of github.com:tensorflow/tensorflow into rel-not…

4e2f762

…es-1-12

googlebot added the cla: no label Oct 5, 2018

goldiegadde requested review from annarev, jsimsa and tatatodd October 5, 2018 20:50

annarev added cla: yes and removed cla: no labels Oct 5, 2018

jsimsa reviewed Oct 5, 2018

View reviewed changes

annarev reviewed Oct 5, 2018

View reviewed changes

Updated after fixing comments

ec7d70e

googlebot added cla: no and removed cla: yes labels Oct 5, 2018

Fix multiline

2edf99e

jsimsa previously approved these changes Oct 5, 2018

View reviewed changes

annarev added cla: yes and removed cla: no labels Oct 5, 2018

goldiegadde requested a review from rajatmonga October 5, 2018 22:25

annarev previously approved these changes Oct 5, 2018

View reviewed changes

tatatodd previously approved these changes Oct 5, 2018

View reviewed changes

Comment thread RELEASE.md Outdated

Comment thread RELEASE.md Outdated

tensorflowbutler assigned rmlarsen Oct 6, 2018

rmlarsen added kokoro:run ready to pull PR ready for merge process labels Oct 6, 2018

tfboyd reviewed Oct 8, 2018

View reviewed changes

Comment thread RELEASE.md Outdated

jsimsa reviewed Oct 8, 2018

View reviewed changes

Comment thread RELEASE.md Outdated

jsimsa reviewed Oct 8, 2018

View reviewed changes

Comment thread RELEASE.md

goldiegadde added 2 commits October 8, 2018 10:52

Merge branch 'r1.12' of github.com:tensorflow/tensorflow into rel-not…

3641e5c

…es-1-12

Address additional comments

5474ecf

tatatodd approved these changes Oct 8, 2018

View reviewed changes

goldiegadde added cla: yes and removed cla: no labels Oct 8, 2018

jsimsa approved these changes Oct 8, 2018

View reviewed changes

annarev approved these changes Oct 8, 2018

View reviewed changes

annarev added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 8, 2018

annarev merged commit 1a6dea3 into r1.12 Oct 8, 2018

annarev deleted the rel-notes-1-12 branch October 8, 2018 18:37

copybara-service Bot mentioned this pull request Feb 17, 2025

PR #22782: [NFC] Move HLO-handling functions from runner to module util. #87424

Closed

copybara-service Bot mentioned this pull request Feb 17, 2025

PR #22782: [NFC] Move HLO-handling functions from runner to module util. #87428

Merged

Conversation

goldiegadde commented Oct 5, 2018

Uh oh!

googlebot commented Oct 5, 2018

Uh oh!

googlebot commented Oct 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

annarev Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

googlebot commented Oct 5, 2018

Uh oh!

googlebot commented Oct 5, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Oct 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

annarev Oct 5, 2018 •

edited

Loading