Improve upgrade script to handle list comprehensions as arguments. #7229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annarev
reviewed
Feb 2, 2017
| if comment_start == -1: | ||
| col = len(prev_line) | ||
| elif find_string_chars.search(prev_line[comment_start:]) is None: | ||
| col = comment_start |
There was a problem hiding this comment.
Should the "col" be one of the return values?
There was a problem hiding this comment.
Tests are forthcoming (I used some to develop this that I haven't codified yet, but work), but I wanted to get this version up asap so that people wouldn't be hit by these problems. I'll put them in now.
There was a problem hiding this comment.
"col" here still looks unused to me. Is it expected?
annarev
reviewed
Feb 3, 2017
| if comment_start == -1: | ||
| col = len(prev_line) | ||
| elif find_string_chars.search(prev_line[comment_start:]) is None: | ||
| col = comment_start |
There was a problem hiding this comment.
"col" here still looks unused to me. Is it expected?
| @@ -134,3 +146,31 @@ def testInplace(self): | |||
|
|
|||
| if __name__ == "__main__": | |||
| test_lib.main() | |||
|
|
|||
| """tf.concat(0, [tf.concat(0, tiles[y]) for y in range(4)]) | |||
There was a problem hiding this comment.
Do you plan to use this comment later on? I am just making sure it is not a typo that you planned to remove.
python's ast module does not return the correct location, so we have to do our best to scan backwards to find where the [ token that trully started the list comprehension occurs.
|
I've added tests now. |
annarev
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python's ast module does not return the correct location, so we
have to do our best to scan backwards to find where the [ token
that trully started the list comprehension occurs.