fix openrouter config load #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the config loading issue by adding support for the openrouter provider in the createProviderConfig function.
- Added a new
case "openrouter"branch to handle OpenRouter provider configs.
Comments suppressed due to low confidence (2)
ui/app/utils/config/models.ts:189
- Add or update unit tests to cover the new
openrouterbranch increateProviderConfigto verify that the correct config object is returned for this provider.
export function createProviderConfig(
ui/app/utils/config/models.ts:192
- Ensure that the ProviderType (and any related enums or type unions) includes "openrouter" so that TypeScript recognizes this new case and prevents type errors.
case "openrouter":
|
recheck |
virajmehta
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the config loading issue for openrouter
Important
Add support for
openrouterincreateProviderConfig()to return a configuration withtypeandmodel_name.openrouterincreateProviderConfig()inmodels.ts, allowing it to return a configuration object withtypeandmodel_name.This description was created by
for d5e2a65. You can customize this summary. It will automatically update as commits are pushed.