Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 10, 2025

Add a new route GET /internal/datasets/{dataset_name}/datapoints/count?{function_name=...} that returns the number of datapoints in a given dataset, optionally with a function. This replaces the old napi count_datapoints_for_dataset_function that also requires taking a function type.

A step towards #5062.


Important

Adds a new route to count datapoints in a dataset, replacing deprecated functionality, with updated handlers and tests.

  • Behavior:
    • Adds GET /internal/datasets/{dataset_name}/datapoints/count route in internal.rs to return datapoint count, optionally filtered by function name.
    • Replaces count_datapoints_for_dataset_function with count_datapoints_for_dataset in dataset_queries.rs.
  • Handlers:
    • Implements get_datapoint_count_handler in get_datapoint_count.rs.
  • Tests:
    • Adds E2E tests in datapoint_count.rs to verify new route functionality.
  • Removals:
    • Deletes CountDatapointsForDatasetFunctionParams.ts and related code.
  • Misc:
    • Updates TensorZeroClient in tensorzero.ts to use new route for datapoint count.
    • Removes deprecated route from routes.ts.

This description was created by Ellipsis for df0291a. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli force-pushed the sl/port-count-inference-by-variant-clickhouse branch from ca7eda3 to 9608492 Compare December 10, 2025 19:23
@shuyangli shuyangli mentioned this pull request Dec 10, 2025
52 tasks
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch 3 times, most recently from f65a7c3 to 0fd57e3 Compare December 10, 2025 20:47
@shuyangli shuyangli force-pushed the sl/port-count-inference-by-variant-clickhouse branch from 9608492 to 6115e2a Compare December 10, 2025 21:07
@shuyangli shuyangli force-pushed the sl/port-count-inference-by-variant-clickhouse branch 5 times, most recently from 7c82b61 to 43a9275 Compare December 11, 2025 03:47
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch from 0fd57e3 to 4caec22 Compare December 11, 2025 03:57
@shuyangli shuyangli force-pushed the sl/port-count-inference-by-variant-clickhouse branch from 43a9275 to 967fb6c Compare December 11, 2025 04:24
@shuyangli shuyangli force-pushed the sl/port-count-inference-by-variant-clickhouse branch 2 times, most recently from 0ef040c to f31467c Compare December 11, 2025 20:01
Base automatically changed from sl/port-count-inference-by-variant-clickhouse to main December 11, 2025 21:08
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch from 4caec22 to 4fc31d9 Compare December 11, 2025 21:19
@shuyangli shuyangli changed the title [Stacked] Port count datapoints query to gateway Port count datapoints query to gateway Dec 11, 2025
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch 4 times, most recently from 8a2cacb to 461317d Compare December 11, 2025 22:07
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch from 461317d to f9ce4f4 Compare December 12, 2025 00:32
@shuyangli shuyangli force-pushed the sl/port-count-datapoints-to-rust branch from f9ce4f4 to c334ad0 Compare December 12, 2025 00:38
@shuyangli shuyangli requested review from GabrielBianconi and removed request for virajmehta December 12, 2025 15:57
@GabrielBianconi GabrielBianconi added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 12, 2025
@shuyangli shuyangli changed the title Port count datapoints query to gateway [Stacked] Port count datapoints query to gateway Dec 12, 2025
@shuyangli shuyangli changed the title [Stacked] Port count datapoints query to gateway Port count datapoints query to gateway Dec 13, 2025
Count datapoints typescript
@shuyangli
Copy link
Member Author

Merge conflict free to stamp

@shuyangli
Copy link
Member Author

/merge-queue

@shuyangli shuyangli enabled auto-merge December 13, 2025 03:43
@github-actions
Copy link
Contributor

πŸš€ Merge queue workflow triggered!

View the run: https://github.com/tensorzero/tensorzero/actions/runs/20186292155

@shuyangli shuyangli added this pull request to the merge queue Dec 13, 2025
Merged via the queue into main with commit 0c3edec Dec 13, 2025
59 of 61 checks passed
@shuyangli shuyangli deleted the sl/port-count-datapoints-to-rust branch December 13, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants