Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate queryEpisodeTable and queryEpisodeTableBounds to gateway #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shuyangli merged 1 commit into from
Dec 12, 2025
Merged

Migrate queryEpisodeTable and queryEpisodeTableBounds to gateway #5131

shuyangli merged 1 commit into from
Dec 12, 2025

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 11, 2025 •
edited by ellipsis-dev bot
Loading

  • Created new HTTP endpoints in the gateway for querying episodes:
    • /internal/episodes - for retrieving episode data with pagination
    • /internal/episodes/bounds - for retrieving episode table bounds
  • Implemented the corresponding handlers in tensorzero-core/src/endpoints/internal/episodes.rs
  • Removed the episode query functionality from the Node.js client and database client

Important

Migrated episode querying to new HTTP endpoints in the gateway, updating client and adding tests.

  • Endpoints:
    • Added /internal/episodes and /internal/episodes/bounds to gateway/src/routes/internal.rs for episode data and bounds.
  • Handlers:
    • Implemented list_episodes_handler and query_episode_table_bounds_handler in list_episodes.rs.
  • Client Updates:
    • Removed queryEpisodeTable and queryEpisodeTableBounds from DatabaseClient in internal/tensorzero-node/src/database.rs.
    • Updated TensorZeroClient in ui/app/utils/tensorzero/tensorzero.ts to use new endpoints.
  • Tests:
    • Added E2E tests in tensorzero-core/tests/e2e/endpoints/internal/episodes.rs for new endpoints.

This description was created by Ellipsis for 49030f4. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 11, 2025
Closed
52 tasks
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from 124ec03 to 46865dc Compare December 11, 2025 17:43
@shuyangli shuyangli marked this pull request as ready for review December 11, 2025 18:00
@shuyangli shuyangli requested a review from virajmehta December 11, 2025 18:00
virajmehta
virajmehta previously approved these changes Dec 11, 2025
View reviewed changes
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from 46865dc to 7085845 Compare December 11, 2025 20:11
@shuyangli shuyangli assigned shuyangli and unassigned virajmehta Dec 11, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch 2 times, most recently from 7d662ba to 774dfda Compare December 11, 2025 20:35
@shuyangli shuyangli assigned virajmehta and unassigned shuyangli Dec 11, 2025
@shuyangli shuyangli enabled auto-merge December 11, 2025 21:14
Aaron1011
Aaron1011 previously approved these changes Dec 11, 2025
View reviewed changes
@shuyangli shuyangli added this pull request to the merge queue Dec 11, 2025
@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Dec 11, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 11, 2025
@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Dec 11, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from 774dfda to 6030339 Compare December 12, 2025 04:26
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch 2 times, most recently from 1c9b374 to 8d61e7f Compare December 12, 2025 14:22
@shuyangli shuyangli enabled auto-merge December 12, 2025 14:28
virajmehta
virajmehta previously approved these changes Dec 12, 2025
View reviewed changes
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from bc27360 to c34f2de Compare December 12, 2025 17:45
virajmehta
virajmehta previously approved these changes Dec 12, 2025
View reviewed changes
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 12, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from c34f2de to 35b03d5 Compare December 12, 2025 18:51
virajmehta
virajmehta previously approved these changes Dec 12, 2025
View reviewed changes
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Dec 12, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Dec 12, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2025
@shuyangli
Add queryEpisodeTable and queryEpisodeTableBounds Rust (#5131)
834cc93
@shuyangli shuyangli force-pushed the sl/migrate-query-episode-table branch from 35b03d5 to 49030f4 Compare December 12, 2025 20:10
@virajmehta virajmehta enabled auto-merge December 12, 2025 20:11
@shuyangli
Copy link
Member Author

shuyangli commented Dec 12, 2025 •
edited
Loading

hmm i think because we ported from UI to e2e, and evaluation data don't match, playwright is failing. let me figure out if i can get some data over that's not right, i couldn't repro locally without code changes? rerunning to see if this is consistently failing

@virajmehta virajmehta added this pull request to the merge queue Dec 12, 2025
@shuyangli
Copy link
Member Author

shuyangli commented Dec 12, 2025

Test is flaky but passing. e2e_tests/optimization.supervised-fine-tuning.spec.ts:106 and e2e_tests/evaluations.eval_name.datapoint_id.spec.ts:18

@shuyangli shuyangli removed this pull request from the merge queue due to a manual request Dec 12, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 6da540c Dec 12, 2025
93 of 95 checks passed
@shuyangli shuyangli deleted the sl/migrate-query-episode-table branch December 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajmehta virajmehta virajmehta approved these changes

@Aaron1011 Aaron1011 Aaron1011 left review comments

Assignees

@virajmehta virajmehta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shuyangli @Aaron1011 @virajmehta