-
Notifications
You must be signed in to change notification settings - Fork 763
Migrate queryMetricsWithFeedback (to get_function_metrics) #5141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e586fc8 to
d0affcb
Compare
Merge activity
|
d0affcb to
5eec110
Compare
5eec110 to
a228992
Compare
a228992 to
b09589d
Compare
b09589d to
22dafb0
Compare
GabrielBianconi
previously approved these changes
Dec 12, 2025
22dafb0 to
9812c91
Compare
GabrielBianconi
previously approved these changes
Dec 12, 2025
9812c91 to
f9ed3d2
Compare
GabrielBianconi
previously approved these changes
Dec 12, 2025
GabrielBianconi
previously approved these changes
Dec 12, 2025
queryMetricsWithFeedback tests and frontend
4b2ae9c to
90be8ac
Compare
Member
Author
|
Merge conflict feel free to stamp |
Member
Author
|
/merge-queue |
Contributor
|
π Merge queue workflow triggered! View the run: https://github.com/tensorzero/tensorzero/actions/runs/20186292009 |
GabrielBianconi
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduce new endpoint to query function metrics with feedback, updating backend logic, API routes, and UI components, with comprehensive tests.
get_function_metrics_handlerininternal.rsto handle new endpoint/internal/functions/{function_name}/metrics.query_metrics_with_feedbackinfeedback.rsto fetch metrics with feedback from ClickHouse.MetricWithFeedbackandMetricsWithFeedbackResponsetypes infeedback.rs.MetricType.ts,MetricWithFeedback.ts, andMetricsWithFeedbackResponse.tsfor TypeScript type definitions.MetricSelector.tsxandCurationMetricSelector.tsxto useMetricsWithFeedbackResponse.feedback_counts.route.tsandOutputSourceSelector.tsxto fetch metrics with feedback.functions.rsto verify new endpoint functionality.queryMetricsWithFeedbacklogic fromfeedback.tsand related tests.This description was created by
for 4b2ae9c. You can customize this summary. It will automatically update as commits are pushed.