Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 11, 2025

Important

Introduce new endpoint to query function metrics with feedback, updating backend logic, API routes, and UI components, with comprehensive tests.

  • Backend:
    • Add get_function_metrics_handler in internal.rs to handle new endpoint /internal/functions/{function_name}/metrics.
    • Implement query_metrics_with_feedback in feedback.rs to fetch metrics with feedback from ClickHouse.
    • Define MetricWithFeedback and MetricsWithFeedbackResponse types in feedback.rs.
  • Bindings:
    • Add MetricType.ts, MetricWithFeedback.ts, and MetricsWithFeedbackResponse.ts for TypeScript type definitions.
  • UI:
    • Update MetricSelector.tsx and CurationMetricSelector.tsx to use MetricsWithFeedbackResponse.
    • Modify routes in feedback_counts.route.ts and OutputSourceSelector.tsx to fetch metrics with feedback.
  • Tests:
    • Add E2E tests in functions.rs to verify new endpoint functionality.
    • Remove old queryMetricsWithFeedback logic from feedback.ts and related tests.

This description was created by Ellipsis for 4b2ae9c. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 11, 2025
52 tasks
@shuyangli shuyangli marked this pull request as ready for review December 11, 2025 20:34
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch 2 times, most recently from e586fc8 to d0affcb Compare December 11, 2025 21:00
@graphite-app
Copy link

graphite-app bot commented Dec 11, 2025

Merge activity

  • Dec 11, 9:09 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Dec 11, 9:09 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from d0affcb to 5eec110 Compare December 11, 2025 21:10
@shuyangli shuyangli enabled auto-merge December 11, 2025 21:11
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from 5eec110 to a228992 Compare December 11, 2025 21:30
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from a228992 to b09589d Compare December 12, 2025 14:41
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from b09589d to 22dafb0 Compare December 12, 2025 16:04
@shuyangli shuyangli changed the title Migrate queryMetricsWithFeedback Migrate queryMetricsWithFeedback (to get_function_metrics) Dec 12, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 12, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from 22dafb0 to 9812c91 Compare December 12, 2025 17:07
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from 9812c91 to f9ed3d2 Compare December 12, 2025 18:07
@shuyangli shuyangli added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2025
queryMetricsWithFeedback tests and frontend
@shuyangli
Copy link
Member Author

Merge conflict feel free to stamp

@shuyangli
Copy link
Member Author

/merge-queue

@shuyangli shuyangli enabled auto-merge December 13, 2025 03:43
@github-actions
Copy link
Contributor

πŸš€ Merge queue workflow triggered!

View the run: https://github.com/tensorzero/tensorzero/actions/runs/20186292009

@shuyangli shuyangli added this pull request to the merge queue Dec 13, 2025
Merged via the queue into main with commit 4309288 Dec 13, 2025
60 checks passed
@shuyangli shuyangli deleted the sl/migrate-query-metrics-with-feedback branch December 13, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants