Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 11, 2025

  • Created a new internal API endpoint /internal/feedback/latest-id-by-metric/{target_id} that returns the most recent feedback ID for each metric associated with a target (inference or episode)

Important

Adds a new internal API endpoint to fetch the latest feedback ID by metric for a given target, with corresponding database query, handler, client updates, and tests.

  • New Endpoint:
    • Adds /internal/feedback/{target_id}/latest-id-by-metric to internal.rs for fetching latest feedback ID by metric.
  • Database:
    • Implements build_latest_feedback_id_by_metric_query() in feedback.rs to construct SQL query.
    • Adds query_latest_feedback_id_by_metric() to FeedbackQueries trait in feedback.rs.
  • Handlers:
    • Adds get_latest_feedback_id_by_metric_handler() in latest_feedback_by_metric.rs.
    • Implements core logic in get_latest_feedback_id_by_metric() in latest_feedback_by_metric.rs.
  • Client:
    • Updates TensorZeroClient in tensorzero.ts to include getLatestFeedbackIdByMetric().
  • Tests:
    • Adds unit tests in latest_feedback_by_metric.rs.
    • Adds E2E tests in feedback.rs to verify endpoint behavior.
  • Misc:
    • Removes queryLatestFeedbackIdByMetric from feedback.ts and updates related imports.

This description was created by Ellipsis for 82fc866. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 11, 2025
52 tasks
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch from a228992 to b09589d Compare December 12, 2025 14:41
@shuyangli shuyangli force-pushed the sl/migrate-query-metrics-with-feedback branch 4 times, most recently from 4b2ae9c to 90be8ac Compare December 13, 2025 03:40
Base automatically changed from sl/migrate-query-metrics-with-feedback to main December 13, 2025 21:22
@shuyangli shuyangli force-pushed the sl/migrate-query-latest-feedback-id-by-metric branch from 918aad3 to 4035d29 Compare December 13, 2025 22:36
@shuyangli shuyangli changed the title [Stacked] Migrate queryLatestFeedbackIdByMetric to gateway Migrate queryLatestFeedbackIdByMetric to gateway Dec 16, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-latest-feedback-id-by-metric branch 2 times, most recently from 3105e7f to 8a37dde Compare December 16, 2025 19:18
@shuyangli shuyangli marked this pull request as ready for review December 16, 2025 19:20
@shuyangli shuyangli requested a review from virajmehta December 16, 2025 19:20
@shuyangli shuyangli force-pushed the sl/migrate-query-latest-feedback-id-by-metric branch from 8a37dde to 5d88599 Compare December 16, 2025 19:29
@shuyangli shuyangli requested review from GabrielBianconi and removed request for virajmehta December 16, 2025 22:15
@shuyangli shuyangli requested review from virajmehta and removed request for GabrielBianconi December 17, 2025 03:23
@graphite-app
Copy link

graphite-app bot commented Dec 17, 2025

Merge activity

  • Dec 17, 3:44 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Dec 17, 3:44 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@shuyangli shuyangli force-pushed the sl/migrate-query-latest-feedback-id-by-metric branch from 5d88599 to 82fc866 Compare December 17, 2025 03:52
@virajmehta virajmehta enabled auto-merge December 17, 2025 04:07
@virajmehta virajmehta added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 807f75c Dec 17, 2025
55 checks passed
@virajmehta virajmehta deleted the sl/migrate-query-latest-feedback-id-by-metric branch December 17, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants