Fix breadcrumb link bug #5146
Merged
Fix breadcrumb link bug #5146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a breadcrumb link bug by adding support for routes that have no index page. It introduces a noLink flag to prevent generating invalid links for breadcrumbs when the route only serves as a layout container without its own content page.
- Adds a
noLinkoptional property to theCrumbIteminterface - Updates breadcrumb link generation logic to respect the
noLinkflag - Applies the fix to the Datapoints route which has no index page
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/app/types/breadcrumbs.ts | Adds optional noLink property to CrumbItem interface |
| ui/app/hooks/use-breadcrumbs.ts | Updates link generation logic to skip creating links when noLink is true |
| ui/app/routes/datapoints/layout.tsx | Marks "Datapoints" breadcrumb as non-linkable since there's no index route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to refactor this whole breadcrumb thing later, it's bad.
Important
Fixes breadcrumb link bug by adding
noLinkproperty to control link generation inuse-breadcrumbs.ts.useBreadcrumbs()inuse-breadcrumbs.tsby adding a check fornoLinkproperty.noLink: truedo not generate a link, even if they are the last segment.Datapointsbreadcrumb inlayout.tsxto usenoLink: true.noLinkproperty toCrumbIteminterface inbreadcrumbs.ts.This description was created by
for d05c7e6. You can customize this summary. It will automatically update as commits are pushed.