-
Notifications
You must be signed in to change notification settings - Fork 762
Improve the efficiency of UI clickhouse queries that use listInferencesWIthPagination
#5160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuyangli
reviewed
Dec 12, 2025
shuyangli
reviewed
Dec 12, 2025
shuyangli
requested changes
Dec 12, 2025
Member
shuyangli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list_inference_metadata looks good; on the frontend one comment about pagination. I'm skeptical of list_episode_inferences - i think worth checking if it actually makes things better.
ui/app/routes/observability/functions/$function_name/variants/route.tsx
Outdated
Show resolved
Hide resolved
shuyangli
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listInferencesWithPaginationis very flexible but not efficient. In cases where we can avoid using it by leveraging existing indices we should do so. This PR adds two routesGET /internal/inference_metadataandGET /internal/episode_inferencesand uses them in the function & variant pages, the inference list when not using complex filtering or search, and the episode route for the episode page.Important
This PR improves UI ClickHouse query efficiency by adding new routes and handlers for inference metadata, updating frontend components to use these routes, and implementing cursor-based pagination.
GET /internal/inference_metadataandGET /internal/episode_inferencesroutes ininternal.rs.list_inference_metadataininference_queries.rsto query inference metadata efficiently.InferenceMetadataandListInferenceMetadataParamsstructs ininferences.rs.get_inference_metadata_handlerininference_metadata.rsto handle new route.FunctionInferenceTable.tsx,VariantInferenceTable.tsx, andInferencesTable.tsxto useInferenceMetadata.route.tsxfiles in function and variant directories to uselistInferenceMetadatafor fetching data.pagination.tsfor cursor-based navigation.inference_metadata.rsto verify new endpoint functionality.package.jsonversion to2025.12.2.This description was created by
for f00545d. You can customize this summary. It will automatically update as commits are pushed.