Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 16, 2025

  • Added a new HTTP endpoint /internal/feedback/{target_id} to retrieve feedback by target ID (inference or episode)

Important

Add new HTTP endpoint /internal/feedback/{target_id} to retrieve feedback by target ID with pagination support.

  • Behavior:
    • Added HTTP endpoint /internal/feedback/{target_id} in internal.rs to retrieve feedback by target ID.
    • New handler get_feedback_by_target_id_handler in get_feedback_by_target_id.rs.
    • Supports pagination with before, after, and limit parameters.
  • Client:
    • Added getFeedbackByTargetId() method in tensorzero.ts for querying feedback by target ID.
    • Removed queryFeedbackByTargetId() from DatabaseClient in index.ts.
  • Tests:
    • Added E2E tests in feedback.rs for the new endpoint, including pagination and error cases.
    • Updated feedback.test.ts to use getFeedbackByTargetId().
  • Misc:
    • Removed QueryFeedbackByTargetIdParams.ts and related code.
    • Updated imports and exports in index.ts and mod.rs.

This description was created by Ellipsis for 0eaada5. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 16, 2025
52 tasks
@shuyangli shuyangli force-pushed the sl/migrate-query-latest-feedback-id-by-metric branch from 5d88599 to 82fc866 Compare December 17, 2025 03:52
Base automatically changed from sl/migrate-query-latest-feedback-id-by-metric to main December 17, 2025 04:55
@shuyangli shuyangli changed the title [Stacked] Migrate queryFeedbackByTargetId Migrate queryFeedbackByTargetId Dec 17, 2025
@shuyangli shuyangli force-pushed the sl/migrate-query-feedback-by-target-id branch from 577b0ae to 94fe249 Compare December 17, 2025 17:04
@shuyangli shuyangli force-pushed the sl/migrate-query-feedback-by-target-id branch 4 times, most recently from 39eba95 to 0047e80 Compare December 17, 2025 17:58
@shuyangli shuyangli force-pushed the sl/migrate-query-feedback-by-target-id branch from 0047e80 to 0eaada5 Compare December 17, 2025 18:28
@shuyangli shuyangli marked this pull request as ready for review December 17, 2025 18:28
Copy link
Member Author

/merge-queue

@github-actions
Copy link
Contributor

πŸš€ Merge queue workflow triggered!

View the run: https://github.com/tensorzero/tensorzero/actions/runs/20313238662

@shuyangli shuyangli added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 1fa349d Dec 17, 2025
100 of 102 checks passed
@shuyangli shuyangli deleted the sl/migrate-query-feedback-by-target-id branch December 17, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants