Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 17, 2025

these are no longer useful after #5156.


Important

Remove deprecated dataset builder NAPI calls and related code, including DatasetQueryParams and associated functions, from the codebase.

  • Removal of Deprecated Code:
    • Remove DatasetQueryParams type and related functions for dataset row operations in lib.rs, DatasetQueryParams.ts, and index.ts.
    • Delete countRowsForDataset, insertRowsForDataset, and countDatasets functions from database.rs and index.ts.
  • Test and Mock Updates:
    • Remove related tests from dataset_queries.rs and update mock implementations in mock_clickhouse_connection_info.rs.
    • Ensure all references to removed functions and types are deleted across the codebase.

This description was created by Ellipsis for f370a4b. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 17, 2025
52 tasks
@shuyangli shuyangli force-pushed the sl/delete-dataset-builder-napi branch from b3fd86f to b36e665 Compare December 17, 2025 20:27
@shuyangli shuyangli marked this pull request as ready for review December 17, 2025 20:28
@shuyangli shuyangli force-pushed the sl/delete-dataset-builder-napi branch 3 times, most recently from a3c6ca7 to 00b7f5c Compare December 17, 2025 21:31
@graphite-app
Copy link

graphite-app bot commented Dec 17, 2025

Merge activity

  • Dec 17, 9:44 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Dec 17, 9:44 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@shuyangli shuyangli force-pushed the sl/delete-dataset-builder-napi branch from 00b7f5c to f370a4b Compare December 17, 2025 21:47
@shuyangli shuyangli requested a review from Aaron1011 December 17, 2025 22:08
@shuyangli shuyangli added this pull request to the merge queue Dec 17, 2025
@Aaron1011 Aaron1011 removed this pull request from the merge queue due to a manual request Dec 17, 2025
@Aaron1011 Aaron1011 added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 8edb764 Dec 18, 2025
55 checks passed
@Aaron1011 Aaron1011 deleted the sl/delete-dataset-builder-napi branch December 18, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants