Delete dataset builder napi calls #5251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are no longer useful after #5156.
Important
Remove deprecated dataset builder NAPI calls and related code, including
DatasetQueryParamsand associated functions, from the codebase.DatasetQueryParamstype and related functions for dataset row operations inlib.rs,DatasetQueryParams.ts, andindex.ts.countRowsForDataset,insertRowsForDataset, andcountDatasetsfunctions fromdatabase.rsandindex.ts.dataset_queries.rsand update mock implementations inmock_clickhouse_connection_info.rs.This description was created by
for f370a4b. You can customize this summary. It will automatically update as commits are pushed.