Migrate getEvaluationRunInfosForDatapoint to backend #5258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc7fc00 to
89dd786
Compare
3d40705 to
bfe7b2d
Compare
- Add get_evaluation_run_infos_for_datapoint to EvaluationQueries trait
- Implement ClickHouse query using TagInference table
- Add route handler at /internal/evaluations/datapoints/{datapoint_id}/run-infos
- Add unit tests with mocks for handler and database layer
- Add e2e tests for endpoint and database queries
- Update TensorZeroClient with new method
- Update UI route to use TensorZeroClient
- Remove unused getEvaluationRunInfosForDatapoint from evaluations.server.ts
bfe7b2d to
5188296
Compare
Member
Author
|
/merge-queue |
Contributor
|
🚀 Merge queue workflow triggered! View the run: https://github.com/tensorzero/tensorzero/actions/runs/20351598805 |
Changed the query to match the old TypeScript version: - Added function_type parameter to determine inference table (ChatInference vs JsonInference) - Query now selects from inference table instead of TagInference - CTE no longer filters by function_name - Gets evaluation_run_id from tags column instead of TagInference value Revert get_evaluation_run_infos_for_datapoint query to old pattern Changed the query to match the old TypeScript version: - Added function_type parameter (FunctionConfigType) to determine inference table - Query now selects from inference table (ChatInference/JsonInference) instead of TagInference - CTE no longer filters by function_name - Gets evaluation_run_id from tags column instead of TagInference value - Gateway computes function_type from config instead of requiring it as query param - Handler validates function exists in config before querying
0268678 to
24a3f89
Compare
shuyangli
commented
Dec 18, 2025
Member
Author
shuyangli
left a comment
There was a problem hiding this comment.
Restored the old SQL
Aaron1011
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Migrate
getEvaluationRunInfosForDatapointto backend with new ClickHouse query and API endpoint, updating UI and tests accordingly.get_evaluation_run_infos_for_datapointtoEvaluationQueriestrait inevaluation_queries.rs.TagInferencetable inevaluation_queries.rs./internal/evaluations/datapoints/{datapoint_id}/run-infosinget_run_infos.rs.evaluation_queries.rsandget_run_infos.rs.evaluation_queries.rsandevaluations.rs.TensorZeroClientwithgetEvaluationRunInfosForDatapointmethod intensorzero.ts.TensorZeroClientinroute.tsx.getEvaluationRunInfosForDatapointfromevaluations.server.ts.This description was created by
for 24a3f89. You can customize this summary. It will automatically update as commits are pushed.