Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shuyangli
Copy link
Member

@shuyangli shuyangli commented Dec 18, 2025

  • Added a new API endpoint /internal/feedback/{target_id}/count to count feedback by target ID

Important

Adds a new endpoint to count feedback by target ID, updates related backend and frontend code, and includes comprehensive tests.

  • Behavior:
    • Adds count_feedback_by_target_id_handler in count_feedback.rs to handle counting feedback by target ID.
    • Adds route /internal/feedback/{target_id}/count in internal.rs.
    • Removes countFeedbackByTargetId method from DatabaseClient in index.ts and database.rs.
  • Types:
    • Renames CountFeedbackByTargetIdParams to CountFeedbackByTargetIdResponse.
    • Updates imports in index.ts and tensorzero.ts to reflect the rename.
  • Tests:
    • Adds E2E tests for counting feedback by target ID in feedback.rs.
    • Tests include cases for valid, multiple, nonexistent, and invalid UUIDs.
  • Frontend:
    • Updates route.tsx to use countFeedbackByTargetId from TensorZeroClient.
    • Updates tensorzero.ts to include countFeedbackByTargetId method.

This description was created by Ellipsis for 6d6aa6f. You can customize this summary. It will automatically update as commits are pushed.

@shuyangli shuyangli mentioned this pull request Dec 18, 2025
52 tasks
@shuyangli shuyangli force-pushed the sl/migrate-count-feedback-by-target-id branch from 2fd39fe to 87c3575 Compare December 18, 2025 16:25
Base automatically changed from sl/migrate-query-feedback-bounds-by-target-id to main December 18, 2025 18:59
@shuyangli shuyangli force-pushed the sl/migrate-count-feedback-by-target-id branch from 87c3575 to f0870a0 Compare December 18, 2025 19:07
@shuyangli shuyangli changed the title [Stacked] Migrate countFeedbackByTargetId Migrate countFeedbackByTargetId Dec 18, 2025
Finish migrating countFeedbackByTargetId to use HTTP client

- Add countFeedbackByTargetId method to TensorZeroClient in tensorzero.ts
- Update episode route to use HTTP client instead of native client
- Remove countFeedbackByTargetId from native node client (lib/index.ts, database.rs)
- Remove CountFeedbackByTargetIdParams binding (no longer needed)
- Regenerate TypeScript bindings
@shuyangli shuyangli force-pushed the sl/migrate-count-feedback-by-target-id branch from f0870a0 to 6d6aa6f Compare December 18, 2025 19:45
@shuyangli shuyangli marked this pull request as ready for review December 18, 2025 19:45
@shuyangli shuyangli requested a review from virajmehta December 18, 2025 19:45
@shuyangli shuyangli requested review from Aaron1011 and removed request for virajmehta December 18, 2025 19:53
@shuyangli shuyangli assigned Aaron1011 and unassigned virajmehta Dec 18, 2025
@shuyangli shuyangli enabled auto-merge December 18, 2025 19:58
@shuyangli shuyangli added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 18, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 18, 2025
@shuyangli shuyangli added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 4eaf273 Dec 18, 2025
57 checks passed
@shuyangli shuyangli deleted the sl/migrate-count-feedback-by-target-id branch December 18, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants