Try to fix flaky 'should show active filter state on button' test #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a flaky end-to-end test by filtering out hidden table elements that were intermittently appearing during test execution. The fix adds a visibility filter to the Playwright locator to avoid selecting cells from a temporarily rendered hidden table.
- Adds
.filter({ visible: true })to the table cell locator in the test "should show active filter state on button"
virajmehta
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
should show active filter state on buttontest to filter visible elements inobservability.inferences.filter.spec.ts.observability.inferences.filter.spec.ts, updateshould show active filter state on buttontest to filter visible elements using.filter({ visible: true })to avoid issues with hidden<table>elements.This description was created by
for 7028ea9. You can customize this summary. It will automatically update as commits are pushed.