Port queryDemonstrationFeedbackByInferenceId to backend #5340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabb024 to
b5d6cf4
Compare
Member
Author
|
/merge-queue |
Contributor
|
🚀 Merge queue workflow triggered! View the run: https://github.com/tensorzero/tensorzero/actions/runs/20385331883 |
b5d6cf4 to
71499b5
Compare
GabrielBianconi
previously approved these changes
Dec 19, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2025
- Add new GET /internal/feedback/demonstration/{inference_id} endpoint
- Add get_demonstration_feedback route handler and core business logic
- Add unit tests using mock FeedbackQueries trait
- Add e2e tests for the new endpoint
- Update TensorZero TypeScript client to use new endpoint
- Delete DatabaseClient from tensorzero-node (no longer needed)
- Delete database.rs from tensorzero-node
- Update UI routes to use new getDemonstrationFeedback method
- Add new GET /internal/feedback/demonstration/{inference_id} endpoint
- Add get_demonstration_feedback route handler and core business logic
- Add unit tests using mock FeedbackQueries trait
- Add e2e tests for the new endpoint
- Update TensorZero TypeScript client to use new endpoint
- Delete DatabaseClient from tensorzero-node (no longer needed)
- Delete database.rs from tensorzero-node
- Update UI routes to use new getDemonstrationFeedback method
71499b5 to
08a8604
Compare
Member
Author
|
Fixed a request validation test failure |
Member
Author
|
/merge-queue |
Contributor
|
🚀 Merge queue workflow triggered! View the run: https://github.com/tensorzero/tensorzero/actions/runs/20388034478 |
GabrielBianconi
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a new endpoint for querying demonstration feedback by inference ID, updates client and UI, and removes deprecated database client code.
GET /internal/feedback/demonstration/{inference_id}endpoint ininternal.rs.get_demonstration_feedback_handlerandget_demonstration_feedbackinget_demonstration_feedback.rs.beforeandafterparameters, rejecting both simultaneously.get_demonstration_feedback.rsusingMockFeedbackQueries.feedback.rsfor the new endpoint.TensorZeroClientintensorzero.tsto use the new endpoint.DatabaseClientand related code fromtensorzero-node.route.tsandroute.tsxto usegetDemonstrationFeedbackmethod.This description was created by
for 08a8604. You can customize this summary. It will automatically update as commits are pushed.