Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add description field to MetricConfig #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GabrielBianconi merged 3 commits into from
Jan 10, 2026
Merged

Add description field to MetricConfig #5459

GabrielBianconi merged 3 commits into from
Jan 10, 2026

Conversation

@anndvision
Copy link
Member

@anndvision anndvision commented Dec 30, 2025 •
edited by ellipsis-dev bot
Loading

Adds an optional description field to MetricConfig, allowing users to document their metrics in the TOML config:

  [metrics.task_success]
  type = "boolean"
  optimize = "max"
  level = "inference"
  description = "Whether the task was completed successfully"

The field is optional and backward-compatible with existing configs.

Important

Add optional description field to MetricConfig for documenting metrics in config.

  • Behavior:
    • Adds optional description field to MetricConfig in MetricConfig.ts and mod.rs.
    • Allows users to document metrics in TOML config.
    • Field is optional and backward-compatible.
  • Tests:
    • Updates test cases in feedback.rs, inference_count_queries.rs, and feedback_queries.rs to include description field with default None.

This description was created by Ellipsis for 07a3cec. You can customize this summary. It will automatically update as commits are pushed.

GabrielBianconi
GabrielBianconi requested changes Jan 10, 2026
View reviewed changes
Copy link
Member

@GabrielBianconi GabrielBianconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change otherwise LGTM

@GabrielBianconi GabrielBianconi added this pull request to the merge queue Jan 10, 2026
Merged via the queue into main with commit c74145c Jan 10, 2026
61 checks passed
@GabrielBianconi GabrielBianconi deleted the andrew/metric-config-description branch January 10, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GabrielBianconi GabrielBianconi GabrielBianconi approved these changes

@Aaron1011 Aaron1011 Awaiting requested review from Aaron1011

@virajmehta virajmehta Awaiting requested review from virajmehta

Assignees

@anndvision anndvision

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anndvision @GabrielBianconi