Implement InferenceQueries for Postgres #5915
Open
+4,251
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f098854 to
f98ca8b
Compare
7c0807d to
a662ea1
Compare
f98ca8b to
73bf4fa
Compare
a662ea1 to
3d54063
Compare
73bf4fa to
b30f8b4
Compare
3d54063 to
cdfd5a9
Compare
fd9a7b3 to
a1c96c6
Compare
b30f8b4 to
e5d90b3
Compare
64cacd9 to
6e9cc21
Compare
a1c96c6 to
9e2cdae
Compare
5bcdb93 to
cb64a5e
Compare
4c85997 to
b8838e8
Compare
cb64a5e to
ac7926c
Compare
ac7926c to
43cfaef
Compare
43cfaef to
c1ca825
Compare
8662a07 to
52b9905
Compare
6cb9d7d to
7bbd8c2
Compare
Base automatically changed from
sl/postgres-feedback-tables-and-writes
to
main
January 28, 2026 22:05
7bbd8c2 to
e232cb9
Compare
d9e5966 to
49130eb
Compare
Member
Author
|
@BugBot review |
49130eb to
d749c33
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
d749c33 to
a20bfa5
Compare
shuyangli
commented
Jan 28, 2026
| message: "Filters are not yet supported for Postgres count queries".to_string(), | ||
| })); | ||
| } | ||
| if params.search_query_experimental.is_some() { |
Member
Author
There was a problem hiding this comment.
need to sort out the index on JSONB columns - we need to add a trgm index on the text representation, and use the same expression in the query
Member
Author
|
@codex review |
|
Codex review is not enabled for this repo. Please contact the admins of this repo to enable Codex. |
Member
Author
|
@claude review |
Uncomment tests Implement delegating trait Push order and limit down to postgres
a20bfa5 to
d5f421f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the main set of inference queries: list/get inferences, insert inferences, count inferences, and so on.
There's some duplication across InferenceQueries and InferenceCountQueries - will remove the InferenceCountQueries later. (Those were directly ported from the frontend.)
Step towards #5691.
Note
Medium Risk
Adds a large new Postgres query implementation and routes core inference/batch write paths through a new dual-write abstraction, which could affect inference persistence and query correctness despite feature-flag gating.
Overview
Implements full Postgres support for
InferenceQueries(list/count inferences, fetch outputs/tool params/output schema, and batch inserts for chat/json inferences), including SQL filter/order-by handling and UNION queries across chat/json tables.Updates the DB abstraction to support inference reads/writes via
DelegatingDatabaseConnectionand adds optional dual-write of chat/json inference rows to Postgres behind feature flags, wiring this through/inferenceand batch inference persistence.Refactors pagination validation into
ListInferencesParams::validate_pagination, addsStoredInferenceDatabase::timestamp(), generates new.sqlxquery metadata, and expands e2e inference query tests to run against both ClickHouse and Postgres.Written by Cursor Bugbot for commit 49130eb. This will update automatically on new commits. Configure here.