-
-
Notifications
You must be signed in to change notification settings - Fork 710
chore: only run validate check on min terraform version #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: only run validate check on min terraform version #114
Conversation
LGTM, but failing. Don't know why. Good night! :) |
I think there is no need to struggle and keep this module compatible with 0.12 which is already out of date anyway. |
v1.39.0 has been just released. |
@antonbabenko Was this not considered a breaking change? Setting the required terraform version to 0.13 would be a breaking change in my opinion since we cannot update now because of our terraform version. My other question is why was the required minimum version of terraform incremented anyways? It does not appear to have any new feature that this module is making use of and is unrelated to the PR unless I am missing something. |
@mike-carey You are right, we bumped the version for no obvious reason (no new features being added) but this was necessary for the failing example where 0.13 syntax was used (see failed run). Yesterday we discussed with @bryantbiggs that we should be able to run @mike-carey Meanwhile, please use v1.38.0 which is for Terraform 0.12. |
Understandable @antonbabenko, thanks for clarifying! The failed build is the part I was missing. We look forward to a potential revert to the minimum version and have pinned the version in the meantime. |
@bryantbiggs Could you make an update to GH Actions to run each |
@antonbabenko yes, I have it on my todo list - will take a look this weekend |
I've opened a PR to revert the module upgrade to 0.13.x while also fixing the CI/CD checks to validate against various min versions of Terraform required depending on the root directory #117 |
v1.40.0 has been just released. Minumum Terraform version is now back to 0.12.x. Thanks, @bryantbiggs ! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?