Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add tags to aws_iam_policy resources #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2021

Conversation

bryantbiggs
Copy link
Member

Description

  • add tags to aws_iam_policy resources

Motivation and Context

  • currently the resources are not tagged

Breaking Changes

  • no

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs bryantbiggs requested a review from antonbabenko May 21, 2021 11:54
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IAM Policy tags were added in 3.35.0 according to CHANGELOG. Could you update versions.tf everywhere?

@bryantbiggs
Copy link
Member Author

@antonbabenko let me know if there are additional changes required when you get a moment

@antonbabenko antonbabenko merged commit bdf695f into terraform-aws-modules:master May 27, 2021
@antonbabenko antonbabenko changed the title chore: add tags to aws_iam_policy resources feat: add tags to aws_iam_policy resources May 27, 2021
@antonbabenko
Copy link
Member

Thanks, Bryant!

v2.3.0 has been just released.

@bryantbiggs bryantbiggs deleted the chore/add-tags branch November 7, 2022 19:18
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants