Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add submodule to handle creation of docker images #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 28, 2021
Merged

feat: Add submodule to handle creation of docker images #162

merged 10 commits into from
Jun 28, 2021

Conversation

Barteus
Copy link
Contributor

@Barteus Barteus commented Jun 21, 2021

Description

Added new submodule which contains docker image creation logic.
The new submodule has a Usage description and is used in the example container-image.

Motivation and Context

Wants to stay DRY for lambdas which require Image packaging.

How Has This Been Tested?

  • I have tested and validated these changes using provided examples/* projects (I have run them to check if change does not break anything)
  • I have added submodule usage using container-image example

@Barteus Barteus changed the title 160 docker image support feat:160 docker image support Jun 21, 2021
@Barteus Barteus changed the title feat:160 docker image support feat: Add support for Docker Image creation and upload as a part of Lambda/Layer creation. Jun 21, 2021
@antonbabenko antonbabenko changed the title feat: Add support for Docker Image creation and upload as a part of Lambda/Layer creation. feat: Add submodule to handle creation of docker images for Lambda functions/layers Jun 28, 2021
@antonbabenko antonbabenko changed the title feat: Add submodule to handle creation of docker images for Lambda functions/layers feat: Add submodule to handle creation of docker images Jun 28, 2021
@antonbabenko antonbabenko merged commit 4a0b616 into terraform-aws-modules:master Jun 28, 2021
@antonbabenko
Copy link
Member

Thanks, @Barteus !

v2.5.0 has been just released.

Fixes #160

@Barteus Barteus deleted the 160-docker-image-support branch June 30, 2021 10:26
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants